Messages in this thread | | | Date | Tue, 27 Aug 2019 11:54:30 +0100 | From | Mark Brown <> | Subject | Re: [PATCH AUTOSEL 5.2 022/123] ASoC: dapm: Fix handling of custom_stop_condition on DAPM graph walks |
| |
On Sun, Aug 25, 2019 at 09:33:42PM -0400, Sasha Levin wrote: > On Wed, Aug 14, 2019 at 10:20:52AM +0100, Mark Brown wrote: > > On Tue, Aug 13, 2019 at 10:09:06PM -0400, Sasha Levin wrote: > > > From: Charles Keepax <ckeepax@opensource.cirrus.com> > > > > > > [ Upstream commit 8dd26dff00c0636b1d8621acaeef3f6f3a39dd77 ] > > > > > > DPCM uses snd_soc_dapm_dai_get_connected_widgets to build a > > > list of the widgets connected to a specific front end DAI so it > > > can search through this list for available back end DAIs. The
> > The DPCM code and its users are rather fragile, if nobody noticed a > > problem I'd worry about causing some other problem to manifest by > > disturbing things.
> Doesn't this patch imply that someone noticed it?
During new development.
> And if not, it'll just break when folks update their kernel...
> If it creates other problems we should address them now rather than > later.
Well, if we don't touch anything hopefully everything will continue to work just as well. DPCM is a bit fragile so I'm nervous about backporting stuff without people actively working with it paying attention to the backports. [unhandled content-type:application/pgp-signature] | |