lkml.org 
[lkml]   [2019]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/9] staging: greybus: fix up SPDX comment in .h files
Hi Greg,

On Tue, Aug 27, 2019 at 09:58:02AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Aug 26, 2019 at 11:21:19AM +0530, Viresh Kumar wrote:
> > On 25-08-19, 07:54, Greg Kroah-Hartman wrote:
> > > When these files originally got an SPDX tag, I used // instead of /* */
> > > for the .h files. Fix this up to use // properly.
> > >
> > > Cc: Viresh Kumar <vireshk@kernel.org>
> > > Cc: Johan Hovold <johan@kernel.org>
> > > Cc: Alex Elder <elder@kernel.org>
> > > Cc: greybus-dev@lists.linaro.org
> > > Cc: devel@driverdev.osuosl.org
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > ---
> > > drivers/staging/greybus/firmware.h | 2 +-
> > > drivers/staging/greybus/gb-camera.h | 2 +-
> > > drivers/staging/greybus/gbphy.h | 2 +-
> > > drivers/staging/greybus/greybus.h | 2 +-
> > > drivers/staging/greybus/greybus_authentication.h | 2 +-
> > > drivers/staging/greybus/greybus_firmware.h | 2 +-
> > > drivers/staging/greybus/greybus_manifest.h | 2 +-
> > > drivers/staging/greybus/greybus_protocols.h | 2 +-
> > > drivers/staging/greybus/greybus_trace.h | 2 +-
> > > drivers/staging/greybus/hd.h | 2 +-
> > > drivers/staging/greybus/interface.h | 2 +-
> > > drivers/staging/greybus/manifest.h | 2 +-
> > > drivers/staging/greybus/module.h | 2 +-
> > > drivers/staging/greybus/operation.h | 2 +-
> > > drivers/staging/greybus/spilib.h | 2 +-
> > > drivers/staging/greybus/svc.h | 2 +-
> > > 16 files changed, 16 insertions(+), 16 deletions(-)
> >
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Thanks for all of the acks!
>
> greg k-h

I found similar issues of graybus when I tested the latest staging-testing

In file included from <command-line>:0:0:
./include/linux/greybus/greybus_protocols.h:45:2: error: unknown type name ‘__le16’
__le16 size; /* Size in bytes of header + payload */
^~~~~~
./include/linux/greybus/greybus_protocols.h:46:2: error: unknown type name ‘__le16’
__le16 operation_id; /* Operation unique id */
^~~~~~
./include/linux/greybus/greybus_protocols.h:47:2: error: unknown type name ‘__u8’
__u8 type; /* E.g GB_I2C_TYPE_* or GB_GPIO_TYPE_* */
^~~~
./include/linux/greybus/greybus_protocols.h:48:2: error: unknown type name ‘__u8’
__u8 result; /* Result of request (in responses only) */
^~~~
./include/linux/greybus/greybus_protocols.h:49:2: error: unknown type name ‘__u8’
__u8 pad[2]; /* must be zero (ignore when read) */
^~~~
./include/linux/greybus/greybus_protocols.h:58:2: error: unknown type name ‘__u8’
__u8 phase;
^~~~
./include/linux/greybus/greybus_protocols.h:88:2: error: unknown type name ‘__u8’
__u8 major;
^~~~
./include/linux/greybus/greybus_protocols.h:89:2: error: unknown type name ‘__u8’
__u8 minor;
^~~~
./include/linux/greybus/greybus_protocols.h:93:2: error: unknown type name ‘__u8’
__u8 major;
^~~~
./include/linux/greybus/greybus_protocols.h:94:2: error: unknown type name ‘__u8’
__u8 minor;
^~~~
./include/linux/greybus/greybus_protocols.h:98:2: error: unknown type name ‘__u8’
__u8 bundle_id;
^~~~
./include/linux/greybus/greybus_protocols.h:102:2: error: unknown type name ‘__u8’
__u8 major;
^~~~
./include/linux/greybus/greybus_protocols.h:103:2: error: unknown type name ‘__u8’
__u8 minor;
^~~~
./include/linux/greybus/greybus_protocols.h:108:2: error: unknown type name ‘__le16’
__le16 size;
^~~~~~
./include/linux/greybus/greybus_protocols.h:113:2: error: unknown type name ‘__u8’
__u8 data[0];
^~~~
./include/linux/greybus/greybus_protocols.h:118:2: error: unknown type name ‘__le16’
__le16 cport_id;
^~~~~~
./include/linux/greybus/greybus_protocols.h:122:2: error: unknown type name ‘__le16’
__le16 cport_id;

.. and other files...

Not very sure... but it seems it can be observed with allmodconfig or
CONFIG_KERNEL_HEADER_TEST=y and fail my compilation...
Hope that of some help (kind reminder...)

Thanks,
Gao Xiang


> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

\
 
 \ /
  Last update: 2019-08-27 11:21    [W:0.069 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site