lkml.org 
[lkml]   [2019]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ext4: change the type of ext4 cache stats to percpu_counter to improve performance
From
Date
Hi Theodore,

On 2019/8/26 23:57, Theodore Y. Ts'o wrote:
> On Mon, Aug 26, 2019 at 04:24:20PM +0800, Shaokun Zhang wrote:
>>> The other problem with this patch is that it initializes
>>> es_stats_cache_hits and es_stats_cache_miesses too late. They will
>>> get used when the journal inode is loaded. This is mostly harmless,
>>
>> I have checked it again, @es_stats_cache_hits and @es_stats_cache_miesses
>> have been initialized before the journal inode is loaded, Maybe I miss
>> something else?
>
> No, sorry, that was my mistake. I misread things when I was looking
> over your patch last night.
>
> Please resubmit your patch once you've fixed things up and tested it.
>

Sure, will do it soon.

> I would recommend that you at least try running your patch using the
> kvm-xfstests's smoke test[1] before submitting them. It will save you
> and me time.
>

Ok, thanks your guidance.

Shaokun,

> [1] https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-quickstart.md
>
> Thanks,
>
> - Ted
>
>
> .
>

\
 
 \ /
  Last update: 2019-08-27 07:47    [W:0.043 / U:1.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site