Messages in this thread | | | Subject | Re: [PATCH net-next] phy: mdio-bcm-iproc: use devm_platform_ioremap_resource() to simplify code | From | Ray Jui <> | Date | Tue, 27 Aug 2019 13:40:08 -0700 |
| |
On 2019-08-27 6:46 a.m., YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/net/phy/mdio-bcm-iproc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/phy/mdio-bcm-iproc.c b/drivers/net/phy/mdio-bcm-iproc.c > index 7d0f388..7e9975d 100644 > --- a/drivers/net/phy/mdio-bcm-iproc.c > +++ b/drivers/net/phy/mdio-bcm-iproc.c > @@ -123,15 +123,13 @@ static int iproc_mdio_probe(struct platform_device *pdev) > { > struct iproc_mdio_priv *priv; > struct mii_bus *bus; > - struct resource *res; > int rc; > > priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); > if (!priv) > return -ENOMEM; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - priv->base = devm_ioremap_resource(&pdev->dev, res); > + priv->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(priv->base)) { > dev_err(&pdev->dev, "failed to ioremap register\n"); > return PTR_ERR(priv->base); >
Looks good to me. Thanks.
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
| |