Messages in this thread Patch in this message | | | Date | Tue, 27 Aug 2019 20:44:37 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 2/8] regulator: add support for SY8824C regulator |
| |
On Tue, Aug 27, 2019 at 08:45:33AM +0000, Jisheng Zhang wrote:
This looks mostly good and I'll apply it, a couple of small things though:
> @@ -0,0 +1,192 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * SY8824C regulator driver > + * Please send a patch which updates the entire comment block to be C++ style so it looks consistent.
> +#define BUCK_EN (1 << 7) > +#define MODE (1 << 6) > +
Please also add prefixes to these to namespace them, especially MODE is likely to collide with something later. [unhandled content-type:application/pgp-signature] | |