lkml.org 
[lkml]   [2019]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RESEND PATCH v3 10/20] mtd: spi-nor: Rework the SPI NOR lock/unlock logic
Date


On 08/27/2019 09:36 AM, Vignesh Raghavendra wrote:
>> + nor->flags = SNOR_F_HAS_LOCK;
> This is okay for now. But Perhaps its safer to do:
>
> nor->flags |= SNOR_F_HAS_LOCK;
>
> so that we don't override flags if set earlier than
> spi_nor_manufacturer_init_params(). I see that patch 20/20 does indeed
> present one such case wrt atmel/Xilinix flashes IIUC

yep, you're right, I'll update as you suggested.

Thanks!
\
 
 \ /
  Last update: 2019-08-27 08:59    [W:0.098 / U:0.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site