lkml.org 
[lkml]   [2019]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] RDMA/mlx5: Merge two enums into a single one
On Sat, Aug 24, 2019 at 10:22:26PM +0530, Souptick Joarder wrote:
> These two enums can be merged into a single one wihtout effecting
> their caller if those were created without intension.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> include/uapi/rdma/mlx5-abi.h | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/include/uapi/rdma/mlx5-abi.h b/include/uapi/rdma/mlx5-abi.h
> index 624f5b53..c89363a 100644
> +++ b/include/uapi/rdma/mlx5-abi.h
> @@ -461,13 +461,10 @@ enum mlx5_ib_mmap_cmd {
> MLX5_IB_MMAP_DEVICE_MEM = 8,
> };
>
> -enum {
> - MLX5_IB_CLOCK_INFO_KERNEL_UPDATING = 1,
> -};
> -
> /* Bit indexes for the mlx5_alloc_ucontext_resp.clock_info_versions bitmap */
> enum {
> MLX5_IB_CLOCK_INFO_V1 = 0,
> + MLX5_IB_CLOCK_INFO_KERNEL_UPDATING = 1,
> };

The enums are used in different contexts, I don't think this is an
improvement

Jason

\
 
 \ /
  Last update: 2019-08-27 17:53    [W:0.027 / U:26.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site