Messages in this thread | | | Date | Tue, 27 Aug 2019 17:37:33 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 0/9] staging: move greybus core out of staging |
| |
On Tue, Aug 27, 2019 at 03:45:57PM +0200, Greg Kroah-Hartman wrote: > Why can't you compile the code? >
Now that I try to investigate the compile errors, it starts to compile perfectly...
> > drivers/staging/greybus/operation.c:379 gb_operation_message_alloc() warn: check 'message_size' for integer overflows 'kzalloc()' > > That should be checked on line 368, right?
This is a false positive. I assumed it was related to the compile problem...
> > > drivers/staging/greybus/light.c:1256 gb_lights_request_handler() warn: 'light->channels' double freed > > drivers/staging/greybus/light.c:1256 gb_lights_request_handler() warn: 'light->name' double freed > > I don't understand this warning, how are these potentially double freed?
I will fix these.
regards, dan carpenter
| |