lkml.org 
[lkml]   [2019]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 05/14] arm64: dts: renesas: r8a77965: Add CMM units
    Hi Jacopo,

    Thank you for the patch.

    On Sun, Aug 25, 2019 at 03:51:45PM +0200, Jacopo Mondi wrote:
    > Add CMM units to Renesas R-Car M3-N device tree and reference them from
    > the Display Unit they are connected to.
    >
    > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

    Apart from the issue with compatible string as pointed out for patch
    03/14,

    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

    > ---
    > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 25 +++++++++++++++++++++++
    > 1 file changed, 25 insertions(+)
    >
    > diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
    > index 4ae163220f60..8cf0d049203d 100644
    > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
    > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
    > @@ -2320,6 +2320,30 @@
    > resets = <&cpg 611>;
    > };
    >
    > + cmm0: cmm@fea40000 {
    > + compatible = "renesas,cmm-r8a77965";
    > + reg = <0 0xfea40000 0 0x1000>;
    > + clocks = <&cpg CPG_MOD 711>;
    > + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
    > + resets = <&cpg 711>;
    > + };
    > +
    > + cmm1: cmm@fea50000 {
    > + compatible = "renesas,cmm-r8a77965";
    > + reg = <0 0xfea50000 0 0x1000>;
    > + clocks = <&cpg CPG_MOD 710>;
    > + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
    > + resets = <&cpg 710>;
    > + };
    > +
    > + cmm3: cmm@fea70000 {
    > + compatible = "renesas,cmm-r8a77965";
    > + reg = <0 0xfea70000 0 0x1000>;
    > + clocks = <&cpg CPG_MOD 708>;
    > + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
    > + resets = <&cpg 708>;
    > + };
    > +
    > csi20: csi2@fea80000 {
    > compatible = "renesas,r8a77965-csi2";
    > reg = <0 0xfea80000 0 0x10000>;
    > @@ -2470,6 +2494,7 @@
    > status = "disabled";
    >
    > vsps = <&vspd0 0>, <&vspd1 0>, <&vspd0 1>;
    > + cmms = <&cmm0 &cmm1 &cmm3>;
    >
    > ports {
    > #address-cells = <1>;

    --
    Regards,

    Laurent Pinchart

    \
     
     \ /
      Last update: 2019-08-27 00:46    [W:4.220 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site