Messages in this thread | | | Date | Tue, 27 Aug 2019 00:14:14 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v3 1/5] leds: lm3532: Fix brightness control for i2c mode |
| |
On Mon 2019-08-26 14:58:22, Tony Lindgren wrote: > Hi, > > * Dan Murphy <dmurphy@ti.com> [190820 19:53]: > > Fix the brightness control for I2C mode. Instead of > > changing the full scale current register update the ALS target > > register for the appropriate banks. > > > > In addition clean up some code errors and random misspellings found > > during coding. > > > > Tested on Droid4 as well as LM3532 EVM connected to a BeagleBoneBlack > > > > Fixes: e37a7f8d77e1 ("leds: lm3532: Introduce the lm3532 LED driver") > > Reported-by: Pavel Machek <pavel@ucw.cz> > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > > --- > > > > v3 - Removed register define updates - https://lore.kernel.org/patchwork/patch/1114542/ > > Looks like starting with this patch in Linux next the LCD on droid4 > is so dim it's unreadable even with brightness set to 255. Setting > brightness to 0 does blank it completely though. > > Did something maybe break with the various patch revisions or are > we now missing some dts patch?
Maybe missing dts patch. We should provide maximum current the LED can handle...
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |