Messages in this thread | | | Date | Mon, 26 Aug 2019 07:10:48 +0000 | From | René van Dorst <> | Subject | Re: [PATCH v2 -next] net: mediatek: remove set but not used variable 'status' |
| |
Let's add Stefan to the conversation. He is the author of this commit.
Quoting Mao Wenan <maowenan@huawei.com>:
> Fixes gcc '-Wunused-but-set-variable' warning: > drivers/net/ethernet/mediatek/mtk_eth_soc.c: In function mtk_handle_irq: > drivers/net/ethernet/mediatek/mtk_eth_soc.c:1951:6: warning: > variable status set but not used [-Wunused-but-set-variable] > > Fixes: 296c9120752b ("net: ethernet: mediatek: Add MT7628/88 SoC support") > Signed-off-by: Mao Wenan <maowenan@huawei.com> > --- > v2: change format of 'Fixes' tag. > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c > b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > index 8ddbb8d..bb7d623 100644 > --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c > +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > @@ -1948,9 +1948,7 @@ static irqreturn_t mtk_handle_irq_tx(int irq, > void *_eth) > static irqreturn_t mtk_handle_irq(int irq, void *_eth) > { > struct mtk_eth *eth = _eth; > - u32 status; > > - status = mtk_r32(eth, MTK_PDMA_INT_STATUS);
Hi Stefan,
You added an extra MTK_PDMA_INT_STATUS read in mtk_handle_irq() Is that read necessary to work properly?
Greats,
René
> if (mtk_r32(eth, MTK_PDMA_INT_MASK) & MTK_RX_DONE_INT) { > if (mtk_r32(eth, MTK_PDMA_INT_STATUS) & MTK_RX_DONE_INT) > mtk_handle_irq_rx(irq, _eth); > -- > 2.7.4
| |