Messages in this thread Patch in this message | | | From | <> | Subject | Re: [PATCH v2 3/6] ASoC: atmel_ssc_dai: implement left-justified data mode | Date | Mon, 26 Aug 2019 14:10:41 +0000 |
| |
> Enable support for left-justified data mode for SSC-codec link. > > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> > > --- > v2: rebased
I noticed you also added a description and you removed two comments from v1. Please include all the changes in the changelog. I already added my 'Reviewed-by' in v1, but since there are some more changes from the previous version:
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Thanks and best regards, Codrin
> > --- > sound/soc/atmel/atmel_ssc_dai.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c > index 7dc6ec9b8c7a..48e9eef34c0f 100644 > --- a/sound/soc/atmel/atmel_ssc_dai.c > +++ b/sound/soc/atmel/atmel_ssc_dai.c > @@ -564,6 +564,15 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream, > > switch (ssc_p->daifmt & SND_SOC_DAIFMT_FORMAT_MASK) { > > + case SND_SOC_DAIFMT_LEFT_J: > + fs_osync = SSC_FSOS_POSITIVE; > + fs_edge = SSC_START_RISING_RF; > + > + rcmr = SSC_BF(RCMR_STTDLY, 0); > + tcmr = SSC_BF(TCMR_STTDLY, 0); > + > + break; > + > case SND_SOC_DAIFMT_I2S: > fs_osync = SSC_FSOS_NEGATIVE; > fs_edge = SSC_START_FALLING_RF; >
| |