lkml.org 
[lkml]   [2019]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net: intel: Cleanup e1000 - add space between }}
From
Date
On Fri, 2019-08-23 at 19:14 +0000, Forrest Fleming wrote:
> suggested by checkpatch
>
> Signed-off-by: Forrest Fleming <ffleming@gmail.com>
> ---
> .../net/ethernet/intel/e1000/e1000_param.c | 28 +++++++++----------
> 1 file changed, 14 insertions(+), 14 deletions(-)

While I do not see an issue with this change, I wonder how important it is
to make such a change. Especially since most of the hardware supported by
this driver is not available for testing. In addition, this is one
suggested change by checkpatch.pl that I personally do not agree with.

This is not a hard NAK, but you have to explain how this change makes the
code more readable before I consider it.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-08-26 10:05    [W:0.066 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site