Messages in this thread | | | Subject | Re: [PATCH 2/7] firmware: add offset to request_firmware_into_buf | From | Scott Branden <> | Date | Fri, 23 Aug 2019 12:44:42 -0700 |
| |
Hi Takashi,
Thanks for review. comments below.
On 2019-08-23 3:05 a.m., Takashi Iwai wrote: > On Thu, 22 Aug 2019 21:24:46 +0200, > Scott Branden wrote: >> Add offset to request_firmware_into_buf to allow for portions >> of firmware file to be read into a buffer. Necessary where firmware >> needs to be loaded in portions from file in memory constrained systems. > AFAIU, this won't work with the fallback user helper, right? Seems to work fine in the fw_run_tests.sh with fallbacks. > Also it won't work for the compressed firmware files as-is. Although unnecessary, seems to work fine in the fw_run_tests.sh with "both" and "xzonly" options. > > So this new API usage is for the limited use cases, hence it needs > such checks and returns error/warns if the condition isn't met. > > IOW, this can't be a simple extension of request_firmware_into_buf() > to pass a new flag. > > > thanks, > > Takashi
| |