Messages in this thread | | | From | Shiju Jose <> | Subject | RE: [PATCH RFC 2/4] ACPI: APEI: Add ghes_handle_memory_failure to the new notification method | Date | Thu, 22 Aug 2019 16:57:04 +0000 |
| |
Hi James,
>-----Original Message----- >From: James Morse [mailto:james.morse@arm.com] >Sent: 21 August 2019 18:23 >To: Shiju Jose <shiju.jose@huawei.com> >Cc: linux-acpi@vger.kernel.org; linux-edac@vger.kernel.org; linux- >kernel@vger.kernel.org; rjw@rjwysocki.net; lenb@kernel.org; >tony.luck@intel.com; bp@alien8.de; baicar@os.amperecomputing.com; >Linuxarm <linuxarm@huawei.com>; Jonathan Cameron ><jonathan.cameron@huawei.com>; tanxiaofei <tanxiaofei@huawei.com> >Subject: Re: [PATCH RFC 2/4] ACPI: APEI: Add ghes_handle_memory_failure to >the new notification method > >Hi, > >On 12/08/2019 11:11, Shiju Jose wrote: >> This patch adds ghes_handle_memory_failure to the new error >> notification method. > >The commit message doesn't answer the question: why? > >The existing code works. This just looks like additional churn. >Given a user, I think the vendor specific example is useful. I don't think making >this thing more pluggable is a good idea. This was intended to replace the number of if(guid_equal(...)) else if(guid_equal(...)) checks in the ghes_do_proc() , which would grow when new UEFI defined error sections would be added in the future. > > >Thanks, > >James
Thanks, Shiju
| |