Messages in this thread | | | Subject | Re: [PATCH v2 3/4] ASoC: qdsp6: q6afe-dai: Update max rate for slim and tdm dais | From | Srinivas Kandagatla <> | Date | Thu, 22 Aug 2019 11:45:48 +0100 |
| |
On 22/08/2019 11:09, Takashi Iwai wrote: > On Thu, 22 Aug 2019 11:56:52 +0200, > Srinivas Kandagatla wrote: >> >> QDSP supports up to 384000 rates on SLIM dais and 352800 rate on TDM dais. >> Add this missing rates. >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> --- >> sound/soc/qcom/qdsp6/q6afe-dai.c | 92 +++++++++++--------------------- >> 1 file changed, 32 insertions(+), 60 deletions(-) >> >> diff --git a/sound/soc/qcom/qdsp6/q6afe-dai.c b/sound/soc/qcom/qdsp6/q6afe-dai.c >> index c1a7624eaf17..ae2baefdb6e2 100644 >> --- a/sound/soc/qcom/qdsp6/q6afe-dai.c >> +++ b/sound/soc/qcom/qdsp6/q6afe-dai.c >> @@ -18,14 +18,14 @@ >> .stream_name = pre" TDM"#num" Playback", \ >> .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |\ >> SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_48000 |\ >> - SNDRV_PCM_RATE_176400, \ >> + SNDRV_PCM_RATE_176400 | SNDRV_PCM_RATE_352800,\ > > This will support a lot more than advertised, e.g. it contains 64000Hz > or 22050Hz. Is this supposed? If yes, mention it clearly in the > changelog, too.
Some of the rates inbetween are not in the DSP supported rate list for TDM.
DSP should return error if we try to set any unsupported rate!
--srini > > thanks, > > Takashi >
| |