lkml.org 
[lkml]   [2019]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: [PATCH] soc: imx: gpcv2: Print the correct error code
    Date
    On Wed, 2019-08-21 at 18:33 +0200, Guido Günther wrote:
    > The current code prints 'ret' (thus 0) while it should use 'err'.
    >
    > Signed-off-by: Guido Günther <agx@sigxcpu.org>

    Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>

    > ---
    > drivers/soc/imx/gpcv2.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
    > index 31b8d002d855..b0dffb06c05d 100644
    > --- a/drivers/soc/imx/gpcv2.c
    > +++ b/drivers/soc/imx/gpcv2.c
    > @@ -198,7 +198,7 @@ static int imx_gpc_pu_pgc_sw_pxx_req(struct
    > generic_pm_domain *genpd,
    > err = regulator_disable(domain->regulator);
    > if (err)
    > dev_err(domain->dev,
    > - "failed to disable regulator: %d\n",
    > ret);
    > + "failed to disable regulator: %d\n",
    > err);
    > /* Preserve earlier error code */
    > ret = ret ?: err;
    > }
    \
     
     \ /
      Last update: 2019-08-22 10:13    [W:5.287 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site