| Date | Wed, 21 Aug 2019 13:34:23 +0200 | From | Frederic Weisbecker <> | Subject | Re: [patch 05/44] posix-cpu-timers: Sanitize bogus WARNONS |
| |
On Mon, Aug 19, 2019 at 04:31:46PM +0200, Thomas Gleixner wrote: > Warning when p == NULL and then proceeding and dereferencing p does not > make any sense as the kernel will crash with a NULL pointer dereference > right away. > > Bailing out when p == NULL and returning an error code does not cure the > underlying problem which caused p to be NULL. Though it might allow to > do proper debugging. > > Same applies to the clock id check in set_process_cpu_timer(). > > Clean them up and make them return without trying to do further damage. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
|