Messages in this thread | | | Subject | Re: [PATCH] cpustat: print watchdog time and statistics of soft and hard interrupts in soft lockup scenes | From | c00423981 <> | Date | Wed, 21 Aug 2019 16:26:17 +0800 |
| |
Sorry, I cannot understand this problem accurately. I try to understand it and I guess what you want to express is that the return value type should be cputime64_t but not u64, just like as follows:
+static cputime64_t cpustat_curr_cputime(int cpu, int index) +{ + cputime64_t time; + + if (index == CPUTIME_IDLE) + time = get_idle_time(cpu); + else if (index == CPUTIME_IOWAIT) + time = get_iowait_time(cpu);
I don't know if I understand it correctly. Looking forward to your answer.
On 2019/8/20 19:04, Peter Zijlstra wrote: > On Mon, Aug 19, 2019 at 03:12:24PM +0800, c00423981 wrote: >> +static u64 cpustat_curr_cputime(int cpu, int index) >> +{ >> + u64 time; >> + >> + if (index == CPUTIME_IDLE) >> + time = get_idle_time(cpu); >> + else if (index == CPUTIME_IOWAIT) >> + time = get_iowait_time(cpu); > > NAK; don't add new users of this terminally broken interface. > >
| |