Messages in this thread | | | Date | Wed, 21 Aug 2019 18:25:07 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] lib/memweight.c: optimize by inlining bitmap_weight() |
| |
On Wed, 21 Aug 2019 10:42:00 +0300 Denis Efremov <efremov@ispras.ru> wrote:
> This patch inlines bitmap_weight() call.
It is better to say the patch "open codes" the bitmap_weight() call.
> Thus, removing the BUG_ON,
Why is that OK to do?
I expect all the code size improvements are from doing this?
> and 'longs to bits -> bits to longs' conversion by directly calling > hweight_long(). > > ./scripts/bloat-o-meter lib/memweight.o.old lib/memweight.o.new > add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-10 (-10) > Function old new delta > memweight 162 152 -10 >
| |