lkml.org 
[lkml]   [2019]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/4] leds: lm3532: Add full scale current configuration
Hi!

> >No need to move ctrl_brt_pointer... to keep order consistent with docs.
>
> OK I will reset the patches and get rid of that change.  I think this got
> moved when I applied the v1 patch.
>
>
> >>+ fs_current_val = led->full_scale_current - LM3532_FS_CURR_MIN /
> >>+ LM3532_FS_CURR_STEP;
> >The computation is wrong ... needs () AFAICT.
>
> Hmm. Doesn't order of operations take precedence?
>
> I will add the () unless checkpatch cribs about them

I may be misunderstanding. What do you expect the computation to be? /
has higher priority than -, right? Can you test it provides expected
results?

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-08-20 18:30    [W:0.072 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site