lkml.org 
[lkml]   [2019]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/4] x86/vmware: Add a header file for hypercall definitions
    On Tue, 20 Aug 2019, Thomas Hellström (VMware) wrote:
    > On 8/20/19 3:42 PM, Thomas Gleixner wrote:
    > > > What confuses me a bit is, if it's clarity we're after, why don't people
    > > > use
    > > >
    > > > #define VMWARE_HYPERCALL \
    > > > ALTERNATIVE_2("inl (%%dx)", \
    > > > "vmcall", X86_FEATURE_VMW_VMCALL, \
    > > > "vmmcall", X86_FEATURE_VMW_VMMCALL)
    > > >
    > > > Seems to build fine here. Is it fear of old assemblers not supporting, for
    > > > example vmmcall
    > > The requirement for binutils is version >= 2.21. If 2.21 supports vmcall and
    > > vmmcall all good.
    > >
    > > Thanks,
    > >
    > > tglx
    >
    > So I tested 2.20.1 and 2.21.1 from ftp.gnu.org/gnu/binutils, and both seem to
    > assemble (as-new) and disassemble (objdump -S) vmcall and vmmcall fine so I
    > think we should be OK using the mnemonic format then.

    Perfect!
    \
     
     \ /
      Last update: 2019-08-20 21:24    [W:2.186 / U:3.488 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site