Messages in this thread | | | Subject | Re: [PATCH] led: triggers: Fix a memory leak bug | From | Jacek Anaszewski <> | Date | Tue, 20 Aug 2019 20:27:36 +0200 |
| |
Hi Wenwen,
Thank you for the patch.
On 8/19/19 10:41 PM, Wenwen Wang wrote: > In led_trigger_set(), 'event' is allocated in kasprintf(). However, it is > not deallocated in the following execution if the label 'err_activate' or > 'err_add_groups' is entered, leading to memory leaks. To fix this issue, > free 'event' before returning the error. > > Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu> > --- > drivers/leds/led-triggers.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c > index 8d11a5e..eff1bda 100644 > --- a/drivers/leds/led-triggers.c > +++ b/drivers/leds/led-triggers.c > @@ -173,6 +173,7 @@ int led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig) > list_del(&led_cdev->trig_list); > write_unlock_irqrestore(&led_cdev->trigger->leddev_list_lock, flags); > led_set_brightness(led_cdev, LED_OFF); > + kfree(event); > > return ret; > } >
Added tag:
Fixes: 52c47742f79d ("leds: triggers: send uevent when changing triggers")
and applied.
-- Best regards, Jacek Anaszewski
| |