Messages in this thread | | | Subject | Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: Add SC7180 pinctrl binding | From | Rajendra Nayak <> | Date | Fri, 2 Aug 2019 12:23:19 +0530 |
| |
On 8/2/2019 12:03 PM, Vinod Koul wrote: > On 02-08-19, 09:45, Rajendra Nayak wrote: >> From: Jitendra Sharma <shajit@codeaurora.org> >> >> Add the binding for the TLMM pinctrl block found in the SC7180 platform >> >> Signed-off-by: Jitendra Sharma <shajit@codeaurora.org> >> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> >> [rnayak: Fix some copy-paste issues, sort and fix functions] >> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> >> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> >> --- > > changes since v1: ..? > >> +- reg-names: >> + Usage: required >> + Value type: <prop-encoded-array> >> + Defintiion: names for the cells of reg, must contain "north", "south" > > s/Defintiion/Definition > >> +Example: >> + >> + tlmm: pinctrl@3000000 { > > this should be: pinctrl@3500000 > > with these two nitpicks fixed:
Thanks Vinod for the review. I will fix these and respin, after I wait a while to see if there is any more feedback :)
> > Reviewed-by: Vinod Koul <vkoul@kernel.org> >
-- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |