Messages in this thread | | | Date | Fri, 2 Aug 2019 15:02:22 -0400 | From | Branden Bonaby <> | Subject | Re: [PATCH 2/3] drivers: hv: vmbus: add fuzz test attributes to sysfs |
| |
On Fri, Aug 02, 2019 at 09:34:40AM +0200, Vitaly Kuznetsov wrote: > Branden Bonaby <brandonbonaby94@gmail.com> writes: > > > Expose the test parameters as part of the sysfs channel attributes. > > We will control the testing state via these attributes. > > > > Signed-off-by: Branden Bonaby <brandonbonaby94@gmail.com> > > --- > > Documentation/ABI/stable/sysfs-bus-vmbus | 22 ++++++ > > drivers/hv/vmbus_drv.c | 97 +++++++++++++++++++++++- > > 2 files changed, 118 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/ABI/stable/sysfs-bus-vmbus b/Documentation/ABI/stable/sysfs-bus-vmbus > > index 8e8d167eca31..239fcb6fdc75 100644 > > --- a/Documentation/ABI/stable/sysfs-bus-vmbus > > +++ b/Documentation/ABI/stable/sysfs-bus-vmbus > > @@ -185,3 +185,25 @@ Contact: Michael Kelley <mikelley@microsoft.com> > > Description: Total number of write operations that encountered an outbound > > ring buffer full condition > > Users: Debugging tools > > + > > +What: /sys/bus/vmbus/devices/<UUID>/fuzz_test_state > > I would prefer this to go under /sys/kernel/debug/ as this is clearly a > debug/test feature. > -- > Vitaly
Alright, it is testing so I see what you mean and why the code in this patch should go in debugfs. Will fix that and resend.
Branden Bonaby
| |