lkml.org 
[lkml]   [2019]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 0/3] software node: Introduce software_node_find_by_name()
From
Date
Hi,

On 19-08-19 12:07, Heikki Krogerus wrote:
> Hi,
>
> There was still one bug spotted by Andy in v2. The role switch node
> was not removed in case of an error (patch 2/3). It is now fixed.
>
>
> The cover letter from v2:
>
> This is the second version of this series where I'm introducing that
> helper.
>
> Hans and Andy! Because of the changes I made to patch 2/3, I'm not
> carrying your reviewed-by tags in it. I would appreciate if you
> could take another look at that patch.
>
> I added a note to the kernel-doc comment in patch 1/3 that the caller
> of the helper function needs to release the ref count after use as
> proposed by Andy.
>
> In patch 2/3, since we have to now modify the role switch descriptor,
> I'm filling the structure in stack memory and removing the constant
> static version. The content of the descriptor is copied during switch
> registration in any case, so we don't need to store it in the driver.
>
> I also noticed a bug in 2/3. I never properly destroyed the software
> node when the mux was removed. That leak is now also fixed.

I've just given this series a try on a device with an ACPI
INT33FE node describing its TypeC connector and the mux is still
properly found and controlled.

So from my pov this series looks ready for merging.

Regards,

Hans

\
 
 \ /
  Last update: 2019-08-19 14:46    [W:0.101 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site