Messages in this thread | | | Date | Sun, 18 Aug 2019 20:07:08 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH V3 4/4] dt-bindings: iio: adc: ad7192: Add binding documentation for AD7192 |
| |
On Sun, 18 Aug 2019 19:46:27 +0100 Jonathan Cameron <jic23@kernel.org> wrote:
> On Wed, 14 Aug 2019 20:39:04 -0600 > Rob Herring <robh+dt@kernel.org> wrote: > > > On Wed, Aug 14, 2019 at 1:32 AM Mircea Caprioru > > <mircea.caprioru@analog.com> wrote: > > > > > > This patch add device tree binding documentation for AD7192 adc in YAML > > > format. > > > > > > Signed-off-by: Mircea Caprioru <mircea.caprioru@analog.com> > > > --- > > > Changelog V2: > > > - remove description from spi and interrupt properties > > > - changed the name of the device from ad7192 to adc in the example > > > > > > Changelog V3: > > > - added semicolon at the end of the dt example > > > > > > .../bindings/iio/adc/adi,ad7192.yaml | 121 ++++++++++++++++++ > > > 1 file changed, 121 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > For some reason, this patch gave me a git error based on encoding. > I applied it by hand instead and all seemed fine. Not sure why > that happened! > > Applied to the togreg branch of iio.git and pushed out as testing > so the autobuilders can play with it. > > Thanks, > > Jonathan > I spoke a bit soon as the build test was still running.
you have const values for the regulators - that doesn't make much sense to my mind and means your example gives warnings...
items: - const: dvdd /iio/Documentation/devicetree/bindings/iio/adc/adi,ad7192.example.dt.yaml: adc@0: dvdd-supply:0: 'dvdd' was expected
I've dropped this and will pick up in v4.
thanks,
Jonathan
| |