lkml.org 
[lkml]   [2019]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/3] usb: roles: intel_xhci: Supplying software node for the role mux
From
Date
Hi,

On 8/16/19 3:52 PM, Heikki Krogerus wrote:
> On Fri, Aug 16, 2019 at 04:45:50PM +0300, Andy Shevchenko wrote:
>> On Fri, Aug 16, 2019 at 1:45 PM Heikki Krogerus
>> <heikki.krogerus@linux.intel.com> wrote:
>>>
>>> The primary purpose for this node will be to allow linking
>>> the users of the switch to it. The users will be for example
>>> USB Type-C connectors. By supplying a reference to this
>>> node in the software nodes representing the USB Type-C
>>> controllers or connectors, the drivers for those devices can
>>> access the switch.
>>
>>> + ret = software_node_register(&intel_xhci_usb_node);
>>> + if (ret)
>>> + return ret;
>>> +
>>> + sw_desc.set = intel_xhci_usb_set_role,
>>> + sw_desc.get = intel_xhci_usb_get_role,
>>> + sw_desc.allow_userspace_control = true,
>>> + sw_desc.fwnode = software_node_fwnode(&intel_xhci_usb_node);
>>> +
>>> data->role_sw = usb_role_switch_register(dev, &sw_desc);
>>> if (IS_ERR(data->role_sw))
>>> return PTR_ERR(data->role_sw);
>>
>> Sounds to me like more fwnode_handle_put() calls are missed.
>
> True. I'll fix it.

I will wait for v3 before testing again then.

Regards,

Hans

\
 
 \ /
  Last update: 2019-08-16 21:56    [W:0.034 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site