Messages in this thread | | | Subject | Re: [PATCH] scsi: lpfc: fix "NULL check before some freeing functions is not needed" | From | James Smart <> | Date | Fri, 16 Aug 2019 11:33:33 -0700 |
| |
On 7/21/2019 4:42 AM, Hariprasad Kelam wrote: > As dma_pool_destroy and mempool_destroy functions has NULL check. We may > not need NULL check before calling them. > > Fix below warnings reported by coccicheck > ./drivers/scsi/lpfc/lpfc_mem.c:252:2-18: WARNING: NULL check before some > freeing functions is not needed. > ./drivers/scsi/lpfc/lpfc_mem.c:255:2-18: WARNING: NULL check before some > freeing functions is not needed. > ./drivers/scsi/lpfc/lpfc_mem.c:258:2-18: WARNING: NULL check before some > freeing functions is not needed. > ./drivers/scsi/lpfc/lpfc_mem.c:261:2-18: WARNING: NULL check before some > freeing functions is not needed. > ./drivers/scsi/lpfc/lpfc_mem.c:265:2-18: WARNING: NULL check before some > freeing functions is not needed. > ./drivers/scsi/lpfc/lpfc_mem.c:269:2-17: WARNING: NULL check before some > freeing functions is not needed. > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> > --- > drivers/scsi/lpfc/lpfc_mem.c | 21 +++++++++------------ > 1 file changed, 9 insertions(+), 12 deletions(-) >
Thanks
Reviewed-by: James Smart <james.smart@broadcom.com>
-- james
| |