Messages in this thread | | | Subject | Re: [PATCH RFC v1] clk: Fix potential NULL dereference in clk_fetch_parent_index() | From | Stephen Boyd <> | Date | Fri, 16 Aug 2019 10:31:47 -0700 |
| |
Quoting Martin Blumenstingl (2019-08-15 23:48:08) > > > I have seen the original crash when I was testing an MMC driver which > > > is not upstream yet on v5.3-rc4. I'm not sure whether this fix is > > > "correct" (it fixes the crash for me) or where to point the Fixes tag > > > to, it may be one of: > > > - fc0c209c147f ("clk: Allow parents to be specified without string names") > > > - 1a079560b145 ("clk: Cache core in clk_fetch_parent_index() without names") > > > > > > This is meant to be applied on top of v5.3-rc4. > > > > > > > Ah ok. I thought that strcmp() would ignore NULL arguments, but > > apparently not. I can apply this to clk-fixes. > at least ARM [0] and the generic [1] implementations don't > > I did not bisect this so do you have any suggestion for a Fixes tag? I > mentioned two candidates above, but I'm not sure which one to use > just let me know, then I'll resend with the fixes tag so you can take > it through clk-fixes > >
I added the fixes tag for the first one, where it was broken, i.e. fc0c209c147f. Thanks.
| |