Messages in this thread | | | Date | Fri, 16 Aug 2019 08:39:25 +0200 | From | Borislav Petkov <> | Subject | Re: [RFC PATCH 00/15] acrn: add the ACRN driver module |
| |
On Fri, Aug 16, 2019 at 10:25:41AM +0800, Zhao Yakui wrote: > The first three patches are the changes under x86/acrn, which adds the > required APIs for the driver and reports the X2APIC caps. > The remaining patches add the ACRN driver module, which accepts the ioctl > from user-space and then communicate with the low-level ACRN hypervisor > by using hypercall.
I have a problem with that: you're adding interfaces to arch/x86/ and its users go into staging. Why? Why not directly put the driver where it belongs, clean it up properly and submit it like everything else is submitted?
I don't want to have stuff in arch/x86/ which is used solely by code in staging and the latter is lingering there indefinitely because no one is cleaning it up...
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |