Messages in this thread | | | Date | Fri, 16 Aug 2019 10:26:42 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH 2/2] lib/test_printf: add test of null/invalid pointer dereference for dentry |
| |
On Fri 2019-08-09 09:24:57, Jia He wrote: > This add some additional test cases of null/invalid pointer dereference > for dentry and file (%pd and %pD) > > Signed-off-by: Jia He <justin.he@arm.com> > --- > lib/test_printf.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/lib/test_printf.c b/lib/test_printf.c > index 944eb50f3862..befedffeb476 100644 > --- a/lib/test_printf.c > +++ b/lib/test_printf.c > @@ -455,6 +455,13 @@ dentry(void) > test("foo", "%pd", &test_dentry[0]); > test("foo", "%pd2", &test_dentry[0]); > > + /* test the null/invalid pointer case for dentry */ > + test("(null)", "%pd", NULL); > + test("(efault)", "%pd", PTR_INVALID); > + /* test the null/invalid pointer case for file */
The two comments mention something that is obvious from the code.
I have pushed the patch as is and removed the comments in a follow up patch [1]. Both are in printk.git, branch for-5.4.
> + test("(null)", "%pD", NULL); > + test("(efault)", "%pD", PTR_INVALID);
Reference: [1] https://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git/commit/?h=for-5.4&id=8ebea6ea1a7ed5d67ecbb2a493c716a2a89c0be2
Best Regards, Petr
| |