lkml.org 
[lkml]   [2019]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next 1/3] net: mdio: add support for passing a PTP system timestamp to the mii_bus driver
On Fri, Aug 16, 2019 at 06:31:55PM +0200, Hubert Feurstein wrote:
>
> int __mdiobus_read(struct mii_bus *bus, int addr, u32 regnum);
> int __mdiobus_write(struct mii_bus *bus, int addr, u32 regnum, u16 val);
> +int __mdiobus_write_sts(struct mii_bus *bus, int addr, u32 regnum, u16 val,
> + struct ptp_system_timestamp *sts);
>
> int mdiobus_read(struct mii_bus *bus, int addr, u32 regnum);
> int mdiobus_read_nested(struct mii_bus *bus, int addr, u32 regnum);
> int mdiobus_write(struct mii_bus *bus, int addr, u32 regnum, u16 val);
> int mdiobus_write_nested(struct mii_bus *bus, int addr, u32 regnum, u16 val);
> +int mdiobus_write_sts(struct mii_bus *bus, int addr, u32 regnum, u16 val,
> + struct ptp_system_timestamp *sts);
> +int mdiobus_write_sts_nested(struct mii_bus *bus, int addr, u32 regnum, u16 val,
> + struct ptp_system_timestamp *sts);

Following the pattern, you have made three new global
mdiobus_write_sts() functions. However, your patch set only uses
mdiobus_write_sts_nested().

Please don't add global functions with no users. Let the first user
add them, if and when the need arises.

Thanks,
Richard

\
 
 \ /
  Last update: 2019-08-17 05:35    [W:0.282 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site