lkml.org 
[lkml]   [2019]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 5/9] drm/panel: Add timings field to drm_panel
    Hi Fabrizio

    On Thu, Aug 15, 2019 at 12:04:29PM +0100, Fabrizio Castro wrote:
    > We need to know if the panel supports dual-link, similarly
    > to bridges, therefore add a reference to drm_timings in
    > drm_panel.

    Why do we need to know this?
    Why is it needed in drm_panel and not in some driver specific struct?

    I cannot see the full series, as I was copied only on some mails.
    Awaiting dri-devel moderator before I can see the rest.

    Sam

    >
    > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
    >
    > ---
    > v1->v2:
    > * new patch
    >
    > include/drm/drm_panel.h | 3 +++
    > 1 file changed, 3 insertions(+)
    >
    > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h
    > index 8c738c0..cd6ff07 100644
    > --- a/include/drm/drm_panel.h
    > +++ b/include/drm/drm_panel.h
    > @@ -26,6 +26,7 @@
    >
    > #include <linux/errno.h>
    > #include <linux/list.h>
    > +#include <drm/drm_timings.h>
    >
    > struct device_node;
    > struct drm_connector;
    > @@ -81,6 +82,7 @@ struct drm_panel_funcs {
    > * struct drm_panel - DRM panel object
    > * @drm: DRM device owning the panel
    > * @connector: DRM connector that the panel is attached to
    > + * @timings: timing information
    > * @dev: parent device of the panel
    > * @link: link from panel device (supplier) to DRM device (consumer)
    > * @funcs: operations that can be performed on the panel
    > @@ -89,6 +91,7 @@ struct drm_panel_funcs {
    > struct drm_panel {
    > struct drm_device *drm;
    > struct drm_connector *connector;
    > + const struct drm_timings *timings;
    > struct device *dev;
    >
    > const struct drm_panel_funcs *funcs;
    > --
    > 2.7.4

    \
     
     \ /
      Last update: 2019-08-15 16:17    [W:4.449 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site