lkml.org 
[lkml]   [2019]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] net: usbnet: fix a memory leak bug
    From
    Date
    Am Mittwoch, den 14.08.2019, 12:41 -0500 schrieb Wenwen Wang:
    > In usbnet_start_xmit(), 'urb->sg' is allocated through kmalloc_array() by
    > invoking build_dma_sg(). Later on, if 'CONFIG_PM' is defined and the if
    > branch is taken, the execution will go to the label 'deferred'. However,
    > 'urb->sg' is not deallocated on this execution path, leading to a memory
    > leak bug.

    Just to make this clear:

    > Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
    NACK

    For the reason Jack explained. Deferral is not a failure.

    Regards
    Oliver

    \
     
     \ /
      Last update: 2019-08-15 12:45    [W:3.275 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site