lkml.org 
[lkml]   [2019]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] kbuild: Require W=1 for -Wimplicit-fallthrough with clang
    On Fri, Aug 16, 2019 at 1:05 AM Nick Desaulniers
    <ndesaulniers@google.com> wrote:
    >
    > On Thu, Aug 15, 2019 at 3:59 PM Miguel Ojeda
    > <miguel.ojeda.sandonis@gmail.com> wrote:
    > >
    > > On Thu, Aug 15, 2019 at 10:45 PM Nathan Chancellor
    > > <natechancellor@gmail.com> wrote:
    > > > * Revert commit bfd77145f35c ("Makefile: Convert -Wimplicit-fallthrough=3
    > > > to just -Wimplicit-fallthrough for clang") for the time being and just
    > > > rely on adding -Wimplicit-fallthrough to KCFLAGS for testing.
    > >
    > > I would avoid applying commits that will have to be reverted just for
    > > Clang, particularly since it is not fully supported yet.
    >
    > "not fully supported yet" you say? *drops monocle*
    > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/MAINTAINERS?h=v5.3-rc4#n4001

    By fully supported I mean it already works and people can rely on it
    out of the box using a released version of Clang/LLVM. Is that the
    case already? If so, many places need updating!

    * include/linux/compiler-clang.h should check for the minimum
    supported version
    * Documentation/process/programming-language.rst should be updated
    * https://github.com/ClangBuiltLinux/linux/wiki does not mention anything

    etc.

    Cheers,
    Miguel

    \
     
     \ /
      Last update: 2019-08-16 01:55    [W:3.592 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site