Messages in this thread | | | From | Hugues FRUCHET <> | Subject | Re: [PATCH v4 1/3] media: stm32-dcmi: improve sensor subdev naming | Date | Wed, 14 Aug 2019 14:17:13 +0000 |
| |
Hi Sakari, Hans,
I've just pushed a v6 with the FIXME we discussed on IRC about "parallel" mbus code versus "serial" mbus code. I have also added some traces to help in debugging if such case occurs.
version 6: - As per Sakari remark: add a FIXME explaining that this version only supports subdevices which expose RGB & YUV "parallel form" mbus code (_2X8) - Add some trace around subdev_call(s_fmt) error & format changes to debug subdev which only expose serial mbus code - Conform to "<name>":<pad index> when tracing subdev infos
Best regards, Hugues.
On 8/9/19 6:01 PM, Sakari Ailus wrote: > Hi Hugues, > > Thanks for teh update. > > On Wed, Jul 31, 2019 at 02:56:21PM +0200, Hugues Fruchet wrote: >> Rename "subdev" entity struct field to "source" >> to prepare for several subdev support. >> Move asd field on top of entity struct. >> >> Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com> >> Change-Id: I1545a1a29a8061ee67cc6e4b799e9a69071911e7 > > No Change-Id tags in the kernel, please. Check the other two as well. > > With that fixed, > > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> > | |