Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 14 Aug 2019 11:04:01 +0200 | Subject | Re: [PATCH] gpio: pl061: Fix the issue failed to register the ACPI interruption |
| |
Hi Wei,
thanks for your patch!
This doesn't apply for my "devel" branch, can you rebase on this: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/log/?h=devel
We have moved some ACPI headers around recently.
On Mon, Aug 12, 2019 at 1:28 PM Wei Xu <xuwei5@hisilicon.com> wrote:
> Invoke acpi_gpiochip_request_interrupts after the acpi data has been > attached to the pl061 acpi node to register interruption.
Makes sense.
> Fixes: 04ce935c6b2a ("gpio: pl061: Pass irqchip when adding gpiochip")
I doubt this is a regression since I haven't seen anyone use this gpiochip with ACPI before.
Please rename the patch "gpio: pl061: Add ACPI support" unless you can convince me it worked without changes before.
Please include some ACPI people on review of this. From MAINTAINERS: ACPI M: "Rafael J. Wysocki" <rjw@rjwysocki.net> M: Len Brown <lenb@kernel.org> L: linux-acpi@vger.kernel.org
I would also include Andy Shevchenko and Mika Westerberg for the GPIO aspects.
Thanks! Linus Walleij
| |