Messages in this thread | | | Date | Wed, 14 Aug 2019 18:42:05 -0400 | From | Joel Fernandes <> | Subject | Re: [PATCH 1/3] workqueue: Convert for_each_wq to use built-in list check (v2) |
| |
On Wed, Aug 14, 2019 at 12:48:41PM -0700, Tejun Heo wrote: > Hello, Joel. > > On Sun, Aug 11, 2019 at 06:11:09PM -0400, Joel Fernandes (Google) wrote: > > list_for_each_entry_rcu now has support to check for RCU reader sections > > as well as lock. Just use the support in it, instead of explicitly > > checking in the caller. > > > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> > > Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
> > #define for_each_pwq(pwq, wq) \ > > - list_for_each_entry_rcu((pwq), &(wq)->pwqs, pwqs_node) \ > > - if (({ assert_rcu_or_wq_mutex(wq); false; })) { } \ > > - else > > + list_for_each_entry_rcu((pwq), &(wq)->pwqs, pwqs_node, \ > > + lock_is_held(&(wq->mutex).dep_map)) > > Why not lockdep_is_held() tho?
Yes, that's better.
thanks,
- Joel
| |