Messages in this thread | | | Subject | Re: [PATCH v4 11/14] net: phy: adin: implement Energy Detect Powerdown mode | From | Florian Fainelli <> | Date | Wed, 14 Aug 2019 10:57:19 -0700 |
| |
On 8/12/2019 4:23 AM, Alexandru Ardelean wrote: > The ADIN PHYs support Energy Detect Powerdown mode, which puts the PHY into > a low power mode when there is no signal on the wire (typically cable > unplugged). > This behavior is enabled by default, but can be disabled via device > property.
We could consider adding a PHY tunable, having this as a Device Tree property amounts to putting a policy inside DT, which is frowned upon.
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Other than that, the code looks fine:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |