lkml.org 
[lkml]   [2019]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 3/4] hwmon/ltc2990: Add platform_data support
    From
    Date
    Hi Guenter,

    Thanks for your feedback!
    Reply below.


    On 08/13/2019 03:24 PM, Guenter Roeck wrote:
    > Sorry, I don't understand. Why exactly can't you replace of_property_read_u32_array()
    > with device_property_read_u32_array() and use fwnode_create_software_node()
    > in the calling code to set the properties ?

    Thanks for this hint.

    Turns out wcove is the only user of fwnode_create_software_node(), and intel_cht_int33fe is the only other driver to contain the string "software_node". Please bear with us if we didn't know about this handy trick yet. And handy it is!

    device_property_read_*() is also really helpful to know about, as it covers both the DT case, as well as other firmware interfaces - thanks for the hint. Is there any reason to ever use of_property_read_*() anymore?

    I've applied your suggested changes, and will send another patch round soon (I want to try one last thing). Please let me/us know what you think once it's on the list.


    Max

    \
     
     \ /
      Last update: 2019-08-14 20:13    [W:5.880 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site