Messages in this thread | | | Date | Tue, 13 Aug 2019 13:48:21 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v7 08/24] erofs: add namei functions |
| |
Hi!
> + /* > + * on-disk error, let's only BUG_ON in the debugging mode. > + * otherwise, it will return 1 to just skip the invalid name > + * and go on (in consideration of the lookup performance). > + */ > + DBG_BUGON(qd->name > qd->end);
I believe you should check for errors in non-debug mode, too.
> + if (unlikely(!ndirents)) { > + DBG_BUGON(1); > + kunmap_atomic(de); > + put_page(page); > + page = ERR_PTR(-EIO); > + goto out; > + }
-EUCLEAN is right error code for corrupted filesystem. (And you probably want to print something to the syslog, too).
Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany [unhandled content-type:application/pgp-signature] | |