lkml.org 
[lkml]   [2019]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 2/4] i2c/busses/i2c-icy: Add LTC2990 present on 2019 board revision
    Hi Max,

    On Tue, Aug 13, 2019 at 1:53 AM Max Staudt <max@enpas.org> wrote:
    > Since the 2019 a1k.org community re-print of these PCBs sports an
    > LTC2990 hwmon chip as an example use case, let this driver autoprobe
    > for that as well. If it is present, modprobing ltc2990 is sufficient.
    >
    > Signed-off-by: Max Staudt <max@enpas.org>

    Thanks for your patch!

    > --- a/drivers/i2c/busses/i2c-icy.c
    > +++ b/drivers/i2c/busses/i2c-icy.c
    > @@ -160,6 +180,8 @@ static void icy_remove(struct zorro_dev *z)
    > {
    > struct icy_i2c *i2c = dev_get_drvdata(&z->dev);
    >
    > + i2c_unregister_device(i2c->client_ltc2990);

    Is this needed?
    In my understanding, i2c_del_adapter() below takes care of that.

    Apart from that, this looks good to me.

    > +
    > i2c_del_adapter(&i2c->adapter);
    > }

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2019-08-13 09:04    [W:3.105 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site