lkml.org 
[lkml]   [2019]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 7/9] mfd: ioc3: Add driver for SGI IOC3 chip
    On Sun, 11 Aug 2019 09:32:12 +0200, Thomas Bogendoerfer wrote:
    > > Also please don't use stdint types in the kernel, please try checkpatch
    > > to catch coding style issues.
    >
    > my patch already reduces them and checkpatch only warns about usage of printk
    > for the network part. Changing that to dev_warn/dev_err in the mfd patch didn't
    > seem the right thing to do. As I'm splitting the conversion patch into a few
    > steps I could also replace the printks.

    Thanks for looking into it. I was referring to the use of uint32_t
    instead of u32. Perhaps checkpatch has to be motivated with the --strict
    option to point those out?

    \
     
     \ /
      Last update: 2019-08-12 21:53    [W:2.651 / U:1.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site