Messages in this thread | | | From | Paul Burton <> | Subject | Re: [PATCH 5/5] MIPS: tlbex: Explicitly cast _PAGE_NO_EXEC to a boolean | Date | Mon, 12 Aug 2019 04:47:24 +0000 |
| |
Hello,
Nathan Chancellor wrote: > clang warns: > > arch/mips/mm/tlbex.c:634:19: error: use of logical '&&' with constant > operand [-Werror,-Wconstant-logical-operand] > if (cpu_has_rixi && _PAGE_NO_EXEC) { > ^ ~~~~~~~~~~~~~ > arch/mips/mm/tlbex.c:634:19: note: use '&' for a bitwise operation > if (cpu_has_rixi && _PAGE_NO_EXEC) { > ^~ > & > arch/mips/mm/tlbex.c:634:19: note: remove constant to silence this > warning > if (cpu_has_rixi && _PAGE_NO_EXEC) { > ~^~~~~~~~~~~~~~~~ > 1 error generated. > > Explicitly cast this value to a boolean so that clang understands we > intend for this to be a non-zero value. > > Fixes: 00bf1c691d08 ("MIPS: tlbex: Avoid placing software PTE bits in Entry* PFN fields")
Applied to mips-next.
> commit c59ae0a10551 > https://git.kernel.org/mips/c/c59ae0a10551 > > Fixes: 00bf1c691d08 ("MIPS: tlbex: Avoid placing software PTE bits in Entry* PFN fields") > Link: https://github.com/ClangBuiltLinux/linux/issues/609 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > Signed-off-by: Paul Burton <paul.burton@mips.com>
Thanks, Paul
[ This message was auto-generated; if you believe anything is incorrect then please email paul.burton@mips.com to report it. ]
| |