Messages in this thread | | | Subject | Re: [PATCH 3/3] staging: erofs: xattr.c: avoid BUG_ON | From | Chao Yu <> | Date | Tue, 13 Aug 2019 11:20:22 +0800 |
| |
On 2019/8/13 10:30, Gao Xiang wrote: > Kill all the remaining BUG_ON in EROFS: > - one BUG_ON was used to detect xattr on-disk corruption, > proper error handling should be added for it instead; > - the other BUG_ONs are used to detect potential issues, > use DBG_BUGON only in (eng) debugging version.
BTW, do we need add WARN_ON() into DBG_BUGON() to show some details function or call stack in where we encounter the issue?
> > Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
| |