Messages in this thread | | | Date | Mon, 12 Aug 2019 17:12:12 -0500 | From | Bjorn Helgaas <> | Subject | Re: [PATCH v2 4/4] PCI: pciehp: Replace pciehp_green_led_{on,off,blink}() |
| |
On Tue, Aug 13, 2019 at 12:14:08AM +0300, Denis Efremov wrote: > > You must have a reason, but why didn't you completely remove > > pciehp_green_led_on(), etc, and change the callers to use > > pciehp_set_indicators() instead? > > Well, I don't have the exact reason here. I thought that it would be nice to preserve > an existing interface and to hide some implementation details (e.g., status of the > second indicator). I could completely remove pciehp_green_led_{on,off,blink}() and > pciehp_set_attention_status() in v3 if you prefer.
I might be missing something, but I do think I would prefer to completely remove pciehp_green_led_{on,off,blink}() and pciehp_set_attention_status(). Then we'd have exactly one interface to change indicator state.
| |