Messages in this thread | | | Date | Sat, 10 Aug 2019 09:03:08 +0200 | From | Greg KH <> | Subject | Re: [PATCH 2/3] soundwire: cadence_master: add debugfs register dump |
| |
On Fri, Aug 09, 2019 at 05:43:40PM -0500, Pierre-Louis Bossart wrote: > +/** > + * sdw_cdns_debugfs_init() - Cadence debugfs init > + * @cdns: Cadence instance > + * @root: debugfs root > + */ > +void sdw_cdns_debugfs_init(struct sdw_cdns *cdns, struct dentry *root) > +{ > + debugfs_create_file("cdns-registers", 0400, root, cdns, &cdns_reg_fops); > +} > +EXPORT_SYMBOL_GPL(sdw_cdns_debugfs_init);
You create this function but never actually call it. Don't add apis that no one uses :(
thanks,
greg k-h
| |