Messages in this thread | | | From | Miguel Ojeda <> | Date | Sat, 10 Aug 2019 15:37:18 +0200 | Subject | Re: checkpatch.pl should suggest __section |
| |
On Sat, Aug 10, 2019 at 12:21 AM Nick Desaulniers <ndesaulniers@google.com> wrote: > > Hi Joe, > While debugging: > https://github.com/ClangBuiltLinux/linux/issues/619 > we found a bunch of places where __section is not used but could be, > and uses a string literal when it probably should not be. > > Just a thought that maybe checkpatch.pl could warn if > `__attribute__((section` appeared in the added diff, and suggest > __section? Then further warn to not use `""` for the section name?
+1 There are a few other attributes that should be renamed, too. It has been on my TODO list for a while, but I decided to go first to add support for the missing ones that we do not have (e.g. __nonnull), so that at some point we could achieve a __attribute__-clean kernel.
But in the mean time, adding this to checkpatch.pl (and other attributes if not there yet) is a great idea!
Cheers, Miguel
| |