Messages in this thread | | | From | Igor Russkikh <> | Subject | Re: [PATCH net-next v2 2/9] net: macsec: move some definitions in a dedicated header | Date | Sat, 10 Aug 2019 12:19:36 +0000 |
| |
Hi Antoine,
Overall good looking patchset, great!
> +/** > + * struct macsec_tx_sa - transmit secure association > + * @active: > + * @next_pn: packet number to use for the next packet > + * @lock: protects next_pn manipulations > + * @key: key structure > + * @stats: per-SA stats > + */ > +struct macsec_tx_sa { > + struct macsec_key key; > + spinlock_t lock; > + u32 next_pn; > + refcount_t refcnt; > + bool active; > + bool offloaded;
I don't see this `offloaded` field being used anywhere. Is this needed?
Regards, Igor
| |